AIP-84 Refactor SortParm #44345
Merged
AIP-84 Refactor SortParm #44345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason810496
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
pierrejeambrun
approved these changes
Nov 26, 2024
|
Need to resolve conflicts. Good to merge |
jason810496
force-pushed
the
feature/AIP-84/refactor-sort-param
branch
from
b0c54cb to
c566985
Compare
|
Resolve conflict, wait for CI ⚙️ |
jason810496
force-pushed
the
feature/AIP-84/refactor-sort-param
branch
from
551d3ab to
54e69ef
Compare
|
Just adapt #44393 to this PR. |
pierrejeambrun
approved these changes
Nov 27, 2024
ArshiaZr
pushed a commit
to ArshiaZr/airflow
that referenced
this pull request
Nov 27, 2024
* Refactor get_connections * Allow Column type for `to_replace` parameter * Refactor get_dags * Refactor get_import_errors * Refactor SortParam, get_dag_runs * Fix default ordering when directly using SortParam - related: apache#44393 * Fix get_list_dag_runs_batch
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* Refactor get_connections * Allow Column type for `to_replace` parameter * Refactor get_dags * Refactor get_import_errors * Refactor SortParam, get_dag_runs * Fix default ordering when directly using SortParam - related: apache#44393 * Fix get_list_dag_runs_batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #42959 (comment)
Refactor
SortParamLeverage the
to_replacefunctionality introduced in #43793 and allow theColumntype to be used in theto_replacedictionary.This change enables the complete removal of
attr_mappingfromSortParam, as most instances ofSortParamdo not requireattr_mapping.