Swap internal RPC server for API server in the helm chart #44463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
potiuk
approved these changes
Nov 28, 2024
hussein-awala
approved these changes
Nov 28, 2024
Member
Author
|
Looks like I've got a lot more tests to fix up though! |
Member
The more he looked inside the more Piglet wasn’t there. |
kaxil
approved these changes
Nov 28, 2024
kaxil
reviewed
Nov 28, 2024
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
I think the failures are just in helm_tests/airflow_core/test_rpc_server.py
Member
Author
|
"Tests / Kubernetes tests / K8S System:LocalExecutor - false - v1.28.13 (pull_request)" is still failing which is really unfortunate, I was hoping that would pass. |
ashb
force-pushed
the
run-api-server-helm-chart
branch
from
be9d396 to
f752f1c
Compare
amoghrajesh
approved these changes
Nov 29, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
Okay, the "Tests / Kubernetes tests / K8S System:LocalExecutor" tests aren't passing because we aren't passing an |
ashb
force-pushed
the
run-api-server-helm-chart
branch
2 times, most recently
from
2384924 to
de9c587
Compare
Previously the PRC server was possible to disable/enable, where as now the new api-server is a required component in Airflow 3.0+ This also does a little bit of drive-by refactoring of the helper templates for service account name generation
ashb
force-pushed
the
run-api-server-helm-chart
branch
from
de9c587 to
086e855
Compare
ashb
commented
Nov 29, 2024
| timeout=300, | ||
| ) | ||
|
|
||
| @pytest.mark.xfail(reason="https://github.com/apache/airflow/issues/44481 needs to be implemented") |
Member
Author
There was a problem hiding this comment.
Please note, I've marked one test as XFail for now.
We merged a change to swap the LocalExecutor over to the new AIP-72 TaskSDK code, and it wasn't complete enough to work with xcom. To unblock main we are temporarirly marking that test as xfail, with a link to the issue to fix it.
ashb
force-pushed
the
run-api-server-helm-chart
branch
from
086e855 to
3d9eb7b
Compare
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Swap internal RPC server for API server in the helm chart Previously the PRC server was possible to disable/enable, where as now the new api-server is a required component in Airflow 3.0+ This also does a little bit of drive-by refactoring of the helper templates for service account name generation * Mark the LocalExecutor test that uses example_xcom dag as xfail for now We merged a change to swap the LocalExecutor over to the new AIP-72 TaskSDK code, and it wasn't complete enough to work with xcom. To unblock main we are temporarirly marking that test as xfail, with a link to the issue to fix it.
2 tasks
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the PRC server was possible to disable/enable, where as now the new
api-server is a required component in Airflow 3.0+
This also does a little bit of drive-by refactoring of the helper templates
for service account name generation
I'm not 100% sure what "default" version is the tests, so maybe me adding a parameterization for "3.0.0" is not right. I also don't know what version we set it the kube/helm tests we run against main etc.
Part of #44436 (and needed to fix main after #44427 was merged)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.