Remove internal_api_call from airflow.secrets.metastore #44489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
remove-internal-api-from-metastore
branch
2 times, most recently
from
b7c93a7 to
672b54f
Compare
|
Tests are 🔴 |
|
Ah... Our favorite: |
|
One of those I want to get rid in airflow 3 by explicit rather than implicit initialization via "airflow.init". |
potiuk
force-pushed
the
remove-internal-api-from-metastore
branch
from
672b54f to
2158dc4
Compare
|
Hopefully green now :) |
shahar1
approved these changes
Nov 29, 2024
Not yet 😅 I was too optimistic |
potiuk
force-pushed
the
remove-internal-api-from-metastore
branch
from
2158dc4 to
cbde852
Compare
|
Variable too... I hate circular imports |
|
Uff :) |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 30, 2024
The changes apache#44490, apache#44491, apache#44489 removed internal_api_call decorator from a few methods but did not remove them from method map. This PR is a follow-up.
potiuk
added a commit
that referenced
this pull request
Nov 30, 2024
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
The changes apache#44490, apache#44491, apache#44489 removed internal_api_call decorator from a few methods but did not remove them from method map. This PR is a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #44436
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.