Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_deprecated_options_with_new_section #44647

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

utkarsharma2
Copy link
Contributor

@utkarsharma2 utkarsharma2 commented Dec 4, 2024

This PR is causing the the CI to break, on branch v2-10-test. It's working in main because we removed the test in this PR. We cannot backport the PR from main as it contains breaking changes. This PR makes the CI green for v2-10-test branch.

@utkarsharma2 utkarsharma2 marked this pull request as draft December 4, 2024 12:33
@utkarsharma2 utkarsharma2 marked this pull request as ready for review December 4, 2024 13:19
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense? Also tagging the author @zachliu

@utkarsharma2 utkarsharma2 merged commit b4f4ba8 into apache:v2-10-test Dec 4, 2024
47 checks passed
@utkarsharma2 utkarsharma2 deleted the fix_broken_test branch December 4, 2024 13:34
utkarsharma2 added a commit that referenced this pull request Dec 4, 2024
@zachliu
Copy link
Contributor

zachliu commented Dec 4, 2024

my pr #44148 (causing the the CI to break on branch v2-10-test) was to fix issue #43794, which, i guess, is caused by harmless miscommunication among contributors (#43040 and #42126 plus only #43040 is incorporated into 2.10.3) ¯\_(ツ)_/¯

utkarsharma2 added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants