Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3668] 'Zoom into sub DAG' button fix #4473

Closed
wants to merge 1 commit into from

Conversation

Jaskon
Copy link

@Jaskon Jaskon commented Jan 10, 2019

'Zoom into sub DAG' button had not shown on the graph.html page in subdag details dialog window

@ron819
Copy link
Contributor

ron819 commented Jan 10, 2019

@Jaskon
Copy link
Author

Jaskon commented Jan 10, 2019

Of course

'Zoom into sub DAG' button had not shown on the graph.html page in subdag details dialog window
@codecov-io
Copy link

Codecov Report

Merging #4473 into master will decrease coverage by 62.85%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4473       +/-   ##
===========================================
- Coverage   79.47%   16.61%   -62.86%     
===========================================
  Files         204      204               
  Lines       16534    16534               
===========================================
- Hits        13140     2747    -10393     
- Misses       3394    13787    +10393
Impacted Files Coverage Δ
airflow/www_rbac/validators.py 0% <0%> (-100%) ⬇️
airflow/utils/log/es_task_handler.py 0% <0%> (-100%) ⬇️
airflow/example_dags/subdags/subdag.py 0% <0%> (-100%) ⬇️
airflow/operators/hive_stats_operator.py 0% <0%> (-100%) ⬇️
airflow/www/validators.py 0% <0%> (-100%) ⬇️
airflow/example_dags/example_docker_operator.py 0% <0%> (-100%) ⬇️
airflow/example_dags/example_subdag_operator.py 0% <0%> (-100%) ⬇️
airflow/api/common/experimental/get_dag_runs.py 0% <0%> (-100%) ⬇️
airflow/www/forms.py 0% <0%> (-100%) ⬇️
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
... and 167 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bc74b...f9f0ba3. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #4473 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4473   +/-   ##
=======================================
  Coverage   79.47%   79.47%           
=======================================
  Files         204      204           
  Lines       16534    16534           
=======================================
  Hits        13140    13140           
  Misses       3394     3394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bc74b...f9f0ba3. Read the comment docs.

@OmerJog
Copy link
Contributor

OmerJog commented Apr 18, 2019

@Jaskon can you rebase?
Due to merge of #4339 the airflow/www was deprecated and the airflow/www_rbac was renamed as airflow/www

@ashb
Copy link
Member

ashb commented Apr 29, 2019

We probably want this fix as it is against v1-10-stable branch to fix this for 1.10.4.

@ashb
Copy link
Member

ashb commented Jul 11, 2019

Not needed anymore. 1.10.4 the code looks like:

        if (d in task_instances)
            try_number = task_instances[d].try_number;
        else
            try_number = 0;
        if (task.task_type == "SubDagOperator")
            call_modal(d, execution_date, try_number, true);
        else
            call_modal(d, execution_date, try_number);

@ashb ashb closed this Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants