-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-3668] 'Zoom into sub DAG' button fix #4473
Conversation
Can you also apply the fix to https://github.com/apache/airflow/blob/master/airflow/www_rbac/templates/airflow/graph.html#L161 |
Of course |
'Zoom into sub DAG' button had not shown on the graph.html page in subdag details dialog window
Codecov Report
@@ Coverage Diff @@
## master #4473 +/- ##
===========================================
- Coverage 79.47% 16.61% -62.86%
===========================================
Files 204 204
Lines 16534 16534
===========================================
- Hits 13140 2747 -10393
- Misses 3394 13787 +10393
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4473 +/- ##
=======================================
Coverage 79.47% 79.47%
=======================================
Files 204 204
Lines 16534 16534
=======================================
Hits 13140 13140
Misses 3394 3394 Continue to review full report at Codecov.
|
We probably want this fix as it is against v1-10-stable branch to fix this for 1.10.4. |
Not needed anymore. 1.10.4 the code looks like: if (d in task_instances)
try_number = task_instances[d].try_number;
else
try_number = 0;
if (task.task_type == "SubDagOperator")
call_modal(d, execution_date, try_number, true);
else
call_modal(d, execution_date, try_number); |
'Zoom into sub DAG' button had not shown on the graph.html page in subdag details dialog window