Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display github-actions[bot] in RC testing issue content #44823

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

amoghrajesh
Copy link
Contributor

Noticed in #44811 that we are displaying the github actions bot in the RC testing issues and thanking it too!

image

We shouldn't be doing that, this PR skips that.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Dec 10, 2024

🤖

Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@kaxil
Copy link
Member

kaxil commented Dec 10, 2024

You broke integration tests with this change :P - https://github.com/apache/airflow/actions/runs/12262659739/job/34212827799?pr=44823

I veto this change ;)-- jk ofcourse -- failure is unrelated

@potiuk
Copy link
Member

potiuk commented Dec 10, 2024

😱 😱 😱 😱 😱 😱 😱 😱 😱 😱

@amoghrajesh
Copy link
Contributor Author

Hahah good one! Its been fixed by #44829

@amoghrajesh amoghrajesh reopened this Dec 11, 2024
@amoghrajesh
Copy link
Contributor Author

Reopening to trigger tests.

@amoghrajesh amoghrajesh merged commit 72b7877 into apache:main Dec 11, 2024
172 of 179 checks passed
ellisms pushed a commit to ellisms/airflow that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants