-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-72: Pass context keys from API Server to Workers #44899
Conversation
c751760
to
ef7be4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looks like a good approach
2170af7
to
f3ea195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits/questions in comments to address, but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good, few comments/qns
Part of apache#44481 This commit augments the TI context available in the Task Execution Interface with the one from the Execution API Server. In future PRs the following will be added: - More methods on TI like ti.xcom_pull, ti.xcom_push etc - Lazy fetching of connections, variables - Verifying the "get_current_context" is working
f3ea195
to
06ae46d
Compare
Part of #44481
This commit augments the TI context available in the Task Execution Interface with the one from the Execution API Server.
In future PRs the following will be added:
f3ea195
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.