Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hatchling on broken canary check #44947

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jscheffl
Copy link
Contributor

Hatchling was released and broke canary. See https://github.com/apache/airflow/actions/runs/12341655218/job/34440551029

This PR makes the needed upgrade

@jscheffl jscheffl requested review from potiuk and ashb as code owners December 15, 2024 22:20
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:dev-tools area:production-image Production image improvements and fixes labels Dec 15, 2024
Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

It seems dependaboat is not working properly on our repo for pip packaging upgrades, some time back we have made changes at dependaboat repo to upgrade dependency under build-requires.

I think it might require some config changes or workflow changes in this repo. I will look into tomorrow.

@amoghrajesh amoghrajesh merged commit 5605cde into apache:main Dec 16, 2024
138 checks passed
@potiuk
Copy link
Member

potiuk commented Dec 16, 2024

It seems dependaboat is not working properly on our repo for pip packaging upgrades, some time back we have made changes at dependaboat repo to upgrade dependency under build-requires.

I think it might require some config changes or workflow changes in this repo. I will look into tomorrow.

Is that change released already ? If so, then I am quite sure we need to configure it - and then we will be able to disable the manual check we have now that breaks canary for build-dependencies.

@potiuk
Copy link
Member

potiuk commented Dec 16, 2024

Nice one BTW!

@gopidesupavan
Copy link
Member

It seems dependaboat is not working properly on our repo for pip packaging upgrades, some time back we have made changes at dependaboat repo to upgrade dependency under build-requires.

I think it might require some config changes or workflow changes in this repo. I will look into tomorrow.

Is that change released already ? If so, then I am quite sure we need to configure it - and then we will be able to disable the manual check we have now that breaks canary for build-dependencies.

Yes its released , oh okay , i thought dependaboat already configured on our repo and could see frequently prs from dependaboat for UI library upgrades.

@potiuk
Copy link
Member

potiuk commented Dec 16, 2024

Yes its released , oh okay , i thought dependaboat already configured on our repo and could see frequently prs from dependaboat for UI library upgrades.

We are using dynamic dependencies generated by hatch_build.py - not stored in pyproject.toml, so we don't use dependabot for Python {yet).

@gopidesupavan
Copy link
Member

Yes its released , oh okay , i thought dependaboat already configured on our repo and could see frequently prs from dependaboat for UI library upgrades.

We are using dynamic dependencies generated by hatch_build.py - not stored in pyproject.toml, so we don't use dependabot for Python {yet).

oh okay, have raised change here #44966. :)

LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
New hatchling version was released.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:dev-tools area:production-image Production image improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants