Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3685] Move licence header check #4497

Merged
merged 3 commits into from
Jan 13, 2019

Conversation

ffinfo
Copy link
Contributor

@ffinfo ffinfo commented Jan 12, 2019

Make sure you have checked all steps below.

Jira

Description

Moving licence header check to a pre-test stage to prevent useless travis resources

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

@ffinfo ffinfo changed the title Move licence header check [AIRFLOW-3685] Move licence header check Jan 12, 2019
@kaxil
Copy link
Member

kaxil commented Jan 12, 2019

+1 this is a good change. Approved. Waiting for the CI to pass.

@BasPH
Copy link
Contributor

BasPH commented Jan 12, 2019

Wow what a coincidence... I was just about to push the PR button and see this. https://issues.apache.org/jira/browse/AIRFLOW-3686

@BasPH
Copy link
Contributor

BasPH commented Jan 12, 2019

My branch is a bit more explicit: master...BasPH:bash-split-license-ci-check. The license check is a separate stage since it's not related to Flake8 IMO:

image

@ffinfo
Copy link
Contributor Author

ffinfo commented Jan 12, 2019

This is my version, in this case flake8 and check licence can run in parallel.
May this best one win ;)

screenshot 2019-01-12 at 13 49 43

@codecov-io
Copy link

codecov-io commented Jan 12, 2019

Codecov Report

Merging #4497 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4497   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files         428      428           
  Lines       29611    29611           
=======================================
  Hits        22135    22135           
  Misses       7476     7476

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c22fe...9851ff6. Read the comment docs.

@kaxil kaxil merged commit d6ab187 into apache:master Jan 13, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Mar 27, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants