Skip to content

Remove default_view property from DAG class and model #45011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove default_view property from DAG class and model #45011

wants to merge 1 commit into from

Conversation

ashb
Copy link
Member

@ashb ashb commented Dec 17, 2024 •
edited
Loading

This doesn't make sense in the new UI in Airflow 3 anymore.

Relates to #43519

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:CLI area:db-migrations PRs with DB migration area:Scheduler including HA (high availability) scheduler area:serialization area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation labels Dec 17, 2024
@ashb
Copy link
Member Author

ashb commented Dec 17, 2024

(Yes, this def needs a news fragment, and likely a rule in our Ruff checks)

@ashb ashb added the legacy api Whether legacy API changes should be allowed in PR label Dec 17, 2024
@ashb ashb closed this Dec 17, 2024
@ashb ashb reopened this Dec 17, 2024
@ashb ashb added the legacy ui Whether legacy UI change should be allowed in PR label Dec 17, 2024
@ashb ashb closed this Dec 17, 2024
@ashb ashb reopened this Dec 17, 2024
@ashb
Remove default_view property from DAG class and model
d9fd25a 
This doesn't make sense in the new UI in Airflow 3 anymore.
@ashb
Copy link
Member Author

ashb commented Dec 18, 2024

cc @uranusjr @Lee-W (I think you are working on ruff rules)

@ashb ashb force-pushed the remove-dag-defaultview branch from bc73b93 to d9fd25a Compare December 18, 2024 09:02
@bbovenzi
Copy link
Contributor

Do we want to remove dag_default_view from the airflow config at the same time or in another PR?

@Lee-W
Copy link
Member

Lee-W commented Dec 18, 2024

cc @uranusjr @Lee-W (I think you are working on ruff rules)

Thanks for reminding us 🙌 I'll add a rule once merged

@ashb
Copy link
Member Author

ashb commented Dec 27, 2024

(If someone wants to finish this off before I'm back on week starting 6th January feel free.)

@potiuk potiuk closed this Jan 11, 2025
@potiuk potiuk deleted the remove-dag-defaultview branch January 11, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk Awaiting requested review from potiuk potiuk will be requested when the pull request is marked ready for review potiuk is a code owner

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:CLI area:db-migrations PRs with DB migration area:Scheduler including HA (high availability) scheduler area:serialization area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation legacy api Whether legacy API changes should be allowed in PR legacy ui Whether legacy UI change should be allowed in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashb @bbovenzi @Lee-W @potiuk