-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator #45025
Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator #45025
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be great to have a unit test to cover this as well
providers/src/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py
Outdated
Show resolved
Hide resolved
self._export_table_to_point_in_time() | ||
return self._export_table_to_point_in_time() | ||
else: | ||
self._export_entire_data() | ||
return self._export_entire_data() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if adding return statement then there is no need for else
…ub.com/tssahota/airflow into return-export-arn-DynamoDBToS3Operator
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
…ub.com/tssahota/airflow into return-export-arn-DynamoDBToS3Operator
else: | ||
self._export_entire_data() | ||
return self._export_table_to_point_in_time() | ||
return self._export_entire_data() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eladkal, sorry for the delay, first time contributor, I assume you mean to remove the else and return the _export_entire_data() function when if condition is False.
Please let me know if there's a better alternative.
_export_table_to_point_in_time.assert_called() | ||
assert export_arn is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mock the exported arn using _export_table_to_point_in_time
and expect that the returned value is the value you set in the mock?
@@ -225,6 +226,7 @@ def _export_entire_data(self): | |||
finally: | |||
if err is None: | |||
_upload_file_to_s3(f, self.s3_bucket_name, self.s3_key_prefix, self.dest_aws_conn_id) | |||
return None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is needed
_export_table_to_point_in_time.assert_called() | ||
assert export_arn is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mock the exported arn using _export_table_to_point_in_time
and expect that the returned value is the value you set in the mock?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Enable DynamoDbToS3Operator to return point in time export ARN to x_com to be used by downstream tasks
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.