Implement Asset.ref for name or URI references #45028
Open
+2,274
−1,719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to refer to an asset without needing the original object, making it easier to schedule against an asset.
I also added some minor improvements to
register_asset_change
so we can save a db query or the asset-model conversion in some cases.There are a couple of possible sytax designs available:
I’m opting for the second one with a factory method since it is easier to implement, but we can discuss which one we like better.