Add dry run for backfill #45062
Open
Add dry run for backfill #45062
+249
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhusneha
force-pushed
the
backfill_dry_run
branch
from
a7a1efd to
d288934
Compare
prabhusneha
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
bbovenzi
reviewed
Dec 19, 2024
| class BackfillRunInfo(BaseModel): | ||
| """Data model for run information during a backfill operation.""" | ||
|
|
||
| logical_date: datetime |
There was a problem hiding this comment.
We will only have logical date, no data interval?
There was a problem hiding this comment.
Since the logical date is a datetime, so for example for DAGs with schedules other than daily, the response will still include the dates on which the backfill will be triggered. I imagine that the user likely has an understanding of the dag's schedule when making a backfill request. Does including the data interval provide additional value in this context?
| ) | ||
| backfill_response_item = [] | ||
| print(info_list) |
There was a problem hiding this comment.
We need to remove print statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44395
Response:
