Session expire on pass change #45139
Open
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a static check failure :) |
potiuk
approved these changes
Dec 21, 2024
amoghrajesh
reviewed
Dec 22, 2024
There was a problem hiding this comment.
@shubhamraj-git nice work on the PR. Could you please change the PR title to something better, like "Invalidate a session on password change"?
| url = make_url(flask_app.config["SQLALCHEMY_DATABASE_URI"]) | ||
| if url.drivername == "sqlite" and url.database and not isabs(url.database): | ||
| raise AirflowConfigException( | ||
| f'Cannot use relative path: `{conf.get("database", "SQL_ALCHEMY_CONN")}` to connect to sqlite. ' |
There was a problem hiding this comment.
Suggested change
| f'Cannot use relative path: `{conf.get("database", "SQL_ALCHEMY_CONN")}` to connect to sqlite. ' | |
| f"Cannot use relative path: `{conf.get("database", "SQL_ALCHEMY_CONN")}` to connect to sqlite." |
Comment on lines
+57
to
+61
| flask_app.config["SQLALCHEMY_DATABASE_URI"] = conf.get("database", "SQL_ALCHEMY_CONN") | ||
| url = make_url(flask_app.config["SQLALCHEMY_DATABASE_URI"]) | ||
| if url.drivername == "sqlite" and url.database and not isabs(url.database): | ||
| raise AirflowConfigException( | ||
| f'Cannot use relative path: `{conf.get("database", "SQL_ALCHEMY_CONN")}` to connect to sqlite. ' |
There was a problem hiding this comment.
Will we be able to cover this using unit tests?
There was a problem hiding this comment.
Because it was a gap so far that wasn't caught, unit tests will ensure that we do not create that gap again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session expire on pass change
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.