-
Notifications
You must be signed in to change notification settings - Fork 16.4k
AIP-72: Allow retrieving Variable from Task Context #45431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amoghrajesh
merged 6 commits into
apache:main
from
astronomer:AIP72-variables-from-context
Jan 7, 2025
Merged
AIP-72: Allow retrieving Variable from Task Context #45431
amoghrajesh
merged 6 commits into
apache:main
from
astronomer:AIP72-variables-from-context
Jan 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
reviewed
Jan 6, 2025
kaxil
reviewed
Jan 6, 2025
kaxil
reviewed
Jan 6, 2025
kaxil
reviewed
Jan 6, 2025
kaxil
reviewed
Jan 6, 2025
kaxil
approved these changes
Jan 6, 2025
Member
kaxil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits but lgtm
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Contributor
Author
|
Unrelated failure. Merging. |
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #45421
Summary of changes
Variableuser-facing definition which will be used in DAG files by DAG authorsObject Glossary
-
VariableResponseis auto-generated and tightly coupled with the API schema.-
VariableResultis runtime-specific and meant for internal communication between Supervisor & Task Runner.-
Variableclass here is where the public-facing, user-relevant aspects are exposed, hiding internal details.Testing
DAG:
This dag tests both the scenarios of a regular
valuecontext as well asjson.Case1: Variables found
Logs:
Case 2: Variable not found
Logs:
TODO:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.