Use setSearchParams after setTableURLState to ensure updates are not overriden by setTableURLState. #45500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overriden by setTableURLState.
tirkarthi
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
|
Thank you for raising this issue! I'll look into it and try to help if I can. |
bbovenzi
approved these changes
Jan 9, 2025
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jan 13, 2025
…overriden by setTableURLState. (apache#45500)
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
…overriden by setTableURLState. (apache#45500)
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…overriden by setTableURLState. (apache#45500)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref : #45095 (comment)
It seems
setTableURLStatealso usessetSearchParamsand the updates tosetSearchParamsbeforesetTableURLStateget overridden inside thesetTableURLStatecall. This looks similar to a reported issue where multiple calls tosetSearchParamsseem to be not safe remix-run/react-router#9757 .