[AIRFLOW-3742] Respect the fallback arg in airflow.configuration.get
#4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This argument is part of the API from our parent class, but we didn't support it because of the various steps we perform in `get()` - this makes it behave more like the parent class, and can simplify a few instances in our code (I've only included one that I found here)
ashb
force-pushed
the
config-parser-fallback-get
branch
from
1636852
to
983dca2
Compare
Codecov Report
@@ Coverage Diff @@
## master #4567 +/- ##
==========================================
+ Coverage 74.11% 74.12% +0.01%
==========================================
Files 421 421
Lines 27681 27675 -6
==========================================
- Hits 20515 20514 -1
+ Misses 7166 7161 -5
Continue to review full report at Codecov.
|
kaxil
approved these changes
Jan 27, 2019
|
LGTM @ashb |
|
LGTM |
6 tasks
|
Fixed up by #4674 |
ashb
added a commit
that referenced
this pull request
Feb 11, 2019
#4567) This argument is part of the API from our parent class, but we didn't support it because of the various steps we perform in `get()` - this makes it behave more like the parent class, and can simplify a few instances in our code (I've only included one that I found here)
wmorris75
pushed a commit
to modmed/incubator-airflow
that referenced
this pull request
Jul 29, 2019
apache#4567) This argument is part of the API from our parent class, but we didn't support it because of the various steps we perform in `get()` - this makes it behave more like the parent class, and can simplify a few instances in our code (I've only included one that I found here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
fallbackargument is part of the API from our parent class, but we didn'tsupport it because of the various steps we perform in
get()- thismakes it behave more like the parent class, and can simplify a few
instances in our code (I've only included one that I found here)
Tests
Commits
Documentation
Code Quality
flake8