Add run_after column to DagRun model #45732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
uranusjr
force-pushed
the
dagrun-run-after
branch
from
f65f709 to
d76a740
Compare
uranusjr
force-pushed
the
dagrun-run-after
branch
10 times, most recently
from
cb4b87a to
8e0022f
Compare
Member
Author
|
Hell yeah this works. We shouldn’t merge this before we resolve the discussion on this, but feel free to review the changes and get an idea what will change (not a lot). |
uranusjr
requested review from
XD-DENG,
ashb,
bbovenzi,
eladkal,
ephraimbuddy,
jedcunningham,
jscheffl,
mobuchowski,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
uranusjr
changed the title
Lee-W
approved these changes
Jan 20, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
one nitpick: everything else looks good
sunank200
approved these changes
Jan 21, 2025
uranusjr
force-pushed
the
dagrun-run-after
branch
from
8e0022f to
58607fc
Compare
1 task
Depending on the run type, the value is set to: * BACKFILL_JOB: DagRunInfo.run_after * SCHEDULED: DagModel.next_run_create_after (this is the same as the backfill variant, only calculated pre-emptively and stored in db) * MANUAL: data_interval.end * ASSET_TRIGGERED: Creation time of the last triggering asset event
uranusjr
force-pushed
the
dagrun-run-after
branch
2 times, most recently
from
475e1d6 to
6db9e07
Compare
uranusjr
force-pushed
the
dagrun-run-after
branch
from
6db9e07 to
8e15fd0
Compare
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Feb 3, 2025
* Add run_after column to DagRun model
* Set run_after when creating DAG run
Depending on the run type, the value is set to:
* BACKFILL_JOB: DagRunInfo.run_after
* SCHEDULED: DagModel.next_run_create_after (this is the same as the
backfill variant, only calculated pre-emptively and stored in db)
* MANUAL: data_interval.end
* ASSET_TRIGGERED: Creation time of the last triggering asset event
* Pass run_after to create_dagrun in tests
* Pass run_after to DagRun in tests
* Set default run_after to now
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 4, 2025
* Add run_after column to DagRun model
* Set run_after when creating DAG run
Depending on the run type, the value is set to:
* BACKFILL_JOB: DagRunInfo.run_after
* SCHEDULED: DagModel.next_run_create_after (this is the same as the
backfill variant, only calculated pre-emptively and stored in db)
* MANUAL: data_interval.end
* ASSET_TRIGGERED: Creation time of the last triggering asset event
* Pass run_after to create_dagrun in tests
* Pass run_after to DagRun in tests
* Set default run_after to now
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
* Add run_after column to DagRun model
* Set run_after when creating DAG run
Depending on the run type, the value is set to:
* BACKFILL_JOB: DagRunInfo.run_after
* SCHEDULED: DagModel.next_run_create_after (this is the same as the
backfill variant, only calculated pre-emptively and stored in db)
* MANUAL: data_interval.end
* ASSET_TRIGGERED: Creation time of the last triggering asset event
* Pass run_after to create_dagrun in tests
* Pass run_after to DagRun in tests
* Set default run_after to now
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* Add run_after column to DagRun model
* Set run_after when creating DAG run
Depending on the run type, the value is set to:
* BACKFILL_JOB: DagRunInfo.run_after
* SCHEDULED: DagModel.next_run_create_after (this is the same as the
backfill variant, only calculated pre-emptively and stored in db)
* MANUAL: data_interval.end
* ASSET_TRIGGERED: Creation time of the last triggering asset event
* Pass run_after to create_dagrun in tests
* Pass run_after to DagRun in tests
* Set default run_after to now
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See AIP-83 amendment to support classic Airflow authoring style and Option 2 clarification doc WIP (Question 3) for context.
This is one of the less controversial approaches to solve ordering and run ID generation for runs with a null logical date.
Depending on the run type, the value is set to: