Make FAB auth manager login process compatible with Airflow 3 UI #45765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
commented
Jan 17, 2025
providers/src/airflow/providers/fab/www/extensions/init_appbuilder.py
Outdated
Show resolved
Hide resolved
pierrejeambrun
approved these changes
Jan 20, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Thanks for the details. Those are answering the question I had on the related PR for the SimpleAuthManager route conversion to FastAPI.
Thanks.
providers/src/airflow/providers/fab/www/extensions/init_appbuilder.py
Outdated
Show resolved
Hide resolved
vincbeck
force-pushed
the
vincbeck/fab_login_form
branch
2 times, most recently
from
e999e14 to
e0bb6ff
Compare
vincbeck
force-pushed
the
vincbeck/fab_login_form
branch
from
e0bb6ff to
bd235fd
Compare
pierrejeambrun
approved these changes
Jan 21, 2025
2 tasks
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
gpathak128
pushed a commit
to gpathak128/airflow
that referenced
this pull request
Jan 29, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan to support FAB auth manager in Airflow 3 is:
WSGIMiddlewarewhen FAB auth manager is the auth manager configured in the Airflow environment. This is done ✅get_url_loginmethod in FAB auth manager to return the appropriate login URL so that the fastapi application can retrieve this value and pass it to the front-end. On the front-end, if the user is not authenticated, it will redirect the user to this URL. It will be done in a future PR.Testing
You can test this PR by going to
<endpoint>/auth/loginand enter credentials. If you get successfully authenticated you'll be redirected to Airflow 3 UI with a JWT token.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.