[AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly #4577

XD-DENG · 2019-01-24T05:15:35Z

Jira

https://issues.apache.org/jira/browse/AIRFLOW-3761

Description

Background

In master branch, we have already decommissioned the Flask-Admin UI.

What have been done

In model definitions, User and Chart are only applicable for the "old" UI based on Flask-Admin. Hence we should decommission these two models as well.
Alembic updated accordingly
Related doc are updated in this commit as well (like profiling section is no longer applicable).

XD-DENG · 2019-01-24T05:17:36Z

Hi @ashb @kaxil @feng-tao PTAL.

This PR is to follow-up on the decommission of "old" UI which was based on Flask-Admin (#4339).

codecov-io · 2019-01-24T06:01:26Z

Codecov Report

Merging #4577 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4577      +/-   ##
==========================================
+ Coverage   74.16%   74.17%   +<.01%     
==========================================
  Files         421      421              
  Lines       27773    27733      -40     
==========================================
- Hits        20598    20570      -28     
+ Misses       7175     7163      -12

Impacted Files	Coverage Δ
airflow/utils/db.py	`38.46% <ø> (+2.74%)`	⬆️
airflow/models/__init__.py	`92.57% <100%> (+0.07%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f70347...5227446. Read the comment docs.

bolkedebruin · 2019-01-24T07:07:24Z

This is not the right way to do it in alembic. You should create a New migration script that drops the tables and fields and re-adds them on a downgrade. The way it is structured now does not properly work with upgrades and downgrades.

XD-DENG · 2019-01-24T07:12:42Z

Thanks @bolkedebruin .

New to Alembic. Let me check & commit again later.

Other than Alembic part, any other comment?

Thanks!

airflow/config_templates/default_airflow.cfg

XD-DENG · 2019-01-25T03:37:54Z

Addressed the comment on Alembic. PTAL @bolkedebruin @ashb

ashb

LGTM. @bolkedebruin any other comments?

XD-DENG · 2019-01-25T11:27:13Z

There is a conflict for docs/profiling.rst now, due to #4585 merged.

docs/profiling.rst should be removed since profiling feature is already deprecated in the RBAC UI.

XD-DENG · 2019-01-27T04:24:56Z

A gentle ping, @ashb @bolkedebruin .

In addition, the conflict I mentioned above was resolved by b6f207f

feng-tao · 2019-01-27T06:58:45Z

@XD-DENG , could you rebase your change with master? I think currently your change shouldn't show docs/profiling.rst delete as it is removed in b6f207f

The Alembic script LGTM

In master branch, we have already decommissioned the Flask-Admin UI. In model definitions, User and Chart are only applicable for the "old" UI based on Flask-Admin. Hence we should decommission these two models as well. Related doc are updated in this commit as well.

XD-DENG · 2019-01-27T07:05:44Z

Rebased as suggested @feng-tao . Thanks.

…gly (apache#4577) In master branch, we have already decommissioned the Flask-Admin UI. In model definitions, User and Chart are only applicable for the "old" UI based on Flask-Admin. Hence we should decommission these two models as well. Related doc are updated in this commit as well.

zhongjiajie · 2020-04-01T06:07:37Z

I think we forgot to cherry-pick this patch to 1.10-test @potiuk @kaxil , and the stable doc was misleading users.
ref #8035

XD-DENG · 2020-04-01T06:14:10Z

Hi @zhongjiajie, there are still two sets of web UI supported in 1.10.*, so this patch should only be in master branch for now. Correct me if I’m wrong.

zhongjiajie · 2020-04-01T06:42:32Z

@XD-DENG You’r right, I find it still use rbac = False in

airflow/airflow/config_templates/default_airflow.cfg

Line 380 in 6f4e3b6

rbac = False

XD-DENG · 2020-04-01T06:45:45Z

@zhongjiajie but you're right that the documentation is somehow out-dated, especially the Security section. Something like LDAP integration becomes misleading & confusing.

I'm preparing a PR to address this issue and further housekeep out-dated code & doc. Will raise the PR soon this week. Will tag you then.

And big congrats again for your nomination as committer! Welcome aboard!

zhongjiajie · 2020-04-01T06:51:00Z

Yeah, I think we should still change the doc, cause user should change the rbac = True and old doc can not work

zhongjiajie · 2020-04-01T06:51:19Z

Thanks Xiao Dong

kaxil · 2020-04-01T11:48:46Z

Good to see you again @XD-DENG . Looking forward for the PR

potiuk · 2020-04-01T11:53:57Z

Indeed good to see you back @XD-DENG !

XD-DENG · 2020-04-01T16:53:29Z

Thanks @kaxil and @potiuk ;-)

- All authentication backends in `airflow/contrib/auth` are base on the `user` model which has already been removed earlier (apache#4577 (comment)) - Security related documentation is out-dated, especially the LDAP and OAuth integration sections. It still directs user to the configuration of "old" web UI which has already been removed in master branch.

- All authentication backends in `airflow/contrib/auth` are base on the `user` model which has already been removed earlier (#4577 (comment)) - Security related documentation is out-dated, especially the LDAP and OAuth integration sections. It still directs user to the configuration of "old" web UI which has already been removed in master branch.

- All authentication backends in `airflow/contrib/auth` are base on the `user` model which has already been removed earlier (apache/airflow#4577 (comment)) - Security related documentation is out-dated, especially the LDAP and OAuth integration sections. It still directs user to the configuration of "old" web UI which has already been removed in master branch. GitOrigin-RevId: 3a7b741ab9ed0937571c77a10b5d244f14eaf7db

ashb reviewed Jan 24, 2019

View reviewed changes

airflow/config_templates/default_airflow.cfg Show resolved Hide resolved

XD-DENG force-pushed the origin/decom_models_users_and_charts branch 3 times, most recently from f3d5e36 to a216889 Compare January 24, 2019 18:35

XD-DENG changed the title ~~[AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly~~ [WIP][AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly Jan 24, 2019

XD-DENG force-pushed the origin/decom_models_users_and_charts branch from a216889 to 5ac3b52 Compare January 24, 2019 19:12

XD-DENG changed the title ~~[WIP][AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly~~ [AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly Jan 24, 2019

ashb approved these changes Jan 25, 2019

View reviewed changes

XD-DENG force-pushed the origin/decom_models_users_and_charts branch from 5ac3b52 to 5227446 Compare January 27, 2019 07:04

feng-tao merged commit 59cf865 into apache:master Jan 27, 2019

XD-DENG deleted the origin/decom_models_users_and_charts branch January 27, 2019 14:19

XD-DENG mentioned this pull request Jan 31, 2019

[WIP][AIRFLOW-3785] Decommission airflow/contrib/auth/backends #4612

Closed

XD-DENG mentioned this pull request Apr 2, 2020

Housekeeping of auth backend & Update Security doc #8071

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly #4577

[AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly #4577

XD-DENG commented Jan 24, 2019 •

edited

Loading

XD-DENG commented Jan 24, 2019

codecov-io commented Jan 24, 2019 •

edited

Loading

bolkedebruin commented Jan 24, 2019

XD-DENG commented Jan 24, 2019

XD-DENG commented Jan 25, 2019

ashb left a comment

XD-DENG commented Jan 25, 2019

XD-DENG commented Jan 27, 2019

feng-tao commented Jan 27, 2019

XD-DENG commented Jan 27, 2019

zhongjiajie commented Apr 1, 2020

XD-DENG commented Apr 1, 2020

zhongjiajie commented Apr 1, 2020

XD-DENG commented Apr 1, 2020

zhongjiajie commented Apr 1, 2020

zhongjiajie commented Apr 1, 2020

kaxil commented Apr 1, 2020

potiuk commented Apr 1, 2020

XD-DENG commented Apr 1, 2020

[AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly #4577

[AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly #4577

Conversation

XD-DENG commented Jan 24, 2019 • edited Loading

Jira

Description

Background

What have been done

XD-DENG commented Jan 24, 2019

codecov-io commented Jan 24, 2019 • edited Loading

Codecov Report

bolkedebruin commented Jan 24, 2019

XD-DENG commented Jan 24, 2019

XD-DENG commented Jan 25, 2019

ashb left a comment

Choose a reason for hiding this comment

XD-DENG commented Jan 25, 2019

XD-DENG commented Jan 27, 2019

feng-tao commented Jan 27, 2019

XD-DENG commented Jan 27, 2019

zhongjiajie commented Apr 1, 2020

XD-DENG commented Apr 1, 2020

zhongjiajie commented Apr 1, 2020

XD-DENG commented Apr 1, 2020

zhongjiajie commented Apr 1, 2020

zhongjiajie commented Apr 1, 2020

kaxil commented Apr 1, 2020

potiuk commented Apr 1, 2020

XD-DENG commented Apr 1, 2020

XD-DENG commented Jan 24, 2019 •

edited

Loading

codecov-io commented Jan 24, 2019 •

edited

Loading