Remove email configs, operator and callbacks#46041
Remove email configs, operator and callbacks#46041hussein-awala wants to merge 11 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
- id: check-no-providers-in-core-examples
language: pygrep
name: No providers imports in core example DAGs
description: The core example DAGs have no dependencies other than standard provider or core Airflow
entry: "^\\s*from airflow\\.providers.(?!standard.)"
pass_filenames: true
files: ^airflow/example_dags/.*\.py$
What about pre-installed providers? if we really want to keep the rule as it is, then I will need to update the example.
There was a problem hiding this comment.
I don't think we should do that. We should keep pre-installed to the minimum necessary.
Probably raise this as one of the items in the lazy consensus
037adbf to
4e7df6e
Compare
|
We need also to remove the email and smtp part of airflow.cfg https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#smtp |
|
I merged #47146 |
|
Do we still want to do this? Happy to help if so. |
Yes. we need to sort this one out before RC1 |
|
We never did anything, and now 3.0 is out… What do we do next? |
Move the email util from airflow-core to smtp provider with airflow4 deprecation warning. |
|
We actually already made some changes and deprecated some configs during task sdk implementation. I think this needs to start from scratch. I’m going to do some of the config changes to catch up with task sdk changes first. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
hooray! this surely simplifies things a lot! |
This PR:
email_on_retryandemail_on_failureto notify the users by email in favor of the SMTP notifierEmailOperatorfromairflow.operators.emailin favor ofairflow.providers.smtp.operators.smtp.EmailOperatorcloses: #30530