Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3789] Fix flake8 3.7 errors. #4617

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Jan 30, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

@@ -134,6 +134,7 @@

import re

from typing import Function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jmcarp , thanks for picking up this Flake8 issue quickly.

May you fix the errors caused by this line?

@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #4617 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4617      +/-   ##
==========================================
+ Coverage   74.25%   74.26%   +<.01%     
==========================================
  Files         423      423              
  Lines       27779    27782       +3     
==========================================
+ Hits        20628    20631       +3     
  Misses       7151     7151
Impacted Files Coverage Δ
airflow/contrib/operators/winrm_operator.py 0% <0%> (ø) ⬆️
airflow/config_templates/airflow_local_settings.py 72.72% <0%> (ø) ⬆️
airflow/contrib/operators/mlengine_operator.py 76.57% <100%> (ø) ⬆️
airflow/contrib/kubernetes/pod_launcher.py 90.16% <100%> (+0.08%) ⬆️
.../kubernetes_request_factory/pod_request_factory.py 100% <100%> (ø) ⬆️
airflow/contrib/operators/ssh_operator.py 83.75% <100%> (ø) ⬆️
airflow/contrib/hooks/gcp_dataflow_hook.py 75.75% <100%> (ø) ⬆️
airflow/contrib/utils/gcp_field_validator.py 91.52% <100%> (+0.07%) ⬆️
airflow/contrib/hooks/imap_hook.py 95.41% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f688f6...f68266d. Read the comment docs.

@ashb ashb merged commit 26d775a into apache:master Jan 30, 2019
@jmcarp
Copy link
Contributor Author

jmcarp commented Jan 30, 2019

Sorry @ashb, I didn't see your comment and force-pushed over your commit.

@ashb
Copy link
Member

ashb commented Jan 30, 2019

No probs - it's quite odd that as a commiter of this repo I can push commits to your PR branch :D. I merged your one though.

ashb pushed a commit to ashb/airflow that referenced this pull request Feb 2, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants