-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Limit google-cloud-aiplatform to fix issues in CI
#46242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
google-cloud-aiplatform to fix issues in CI
|
Can you also create an issue for that so we do not forget to take care of that later ? |
|
Seems next canary is also failing as the PR is open: https://github.com/apache/airflow/actions/runs/13038931877/job/36376833483 |
|
I think we can merge if failures are unrelated to unblock |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Merging. All errors in CI checks are residual leftovers of other problems, this PR still improves the broken main state. |
* Adding sklearn as a dependency for google provider * limiting google cloud aiplatform instead * Add link to bug ticket --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Adding sklearn as a dependency for google provider * limiting google cloud aiplatform instead * Add link to bug ticket --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Adding sklearn as a dependency for google provider * limiting google cloud aiplatform instead * Add link to bug ticket --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Adding sklearn as a dependency for google provider * limiting google cloud aiplatform instead * Add link to bug ticket --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Adding sklearn as a dependency for google provider * limiting google cloud aiplatform instead * Add link to bug ticket --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
From the last failure https://github.com/apache/airflow/actions/runs/13032455156/job/36355532907, looks like sklearn is not a dependency on google provider. Using the latest stable version: https://scikit-learn.org/stable/auto_examples/release_highlights/plot_release_highlights_1_6_0.html
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.