[providers-fab/v1-5] Use different default algorithms for different werkzeug versions (#46384) #46392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Feb 3, 2025
The scikit-learn is an optional dependency of the library from google and apparently we are using the `evaluation` optional feature of it. Adding the extra should make google provider depends on scikit-learn. Closes: #46258 Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> (cherry picked from commit baf54a8)
Member
|
Just random failure - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older werkzeug uses different algorithms for different versions - we
should match the default algorithm for those versions.
(cherry picked from commit dafd166)
Co-authored-by: Jarek Potiuk jarek@potiuk.com