AIP-84 Add login endpoint to the public url #46627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
ephraimbuddy,
jscheffl and
ryanahamilton
as code owners
vincbeck
reviewed
Feb 10, 2025
vincbeck
approved these changes
Feb 10, 2025
jedcunningham
approved these changes
Feb 10, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* Add login endpoint to the public url * Add tests, handle next * Fix CI * Another Fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 2 of: #44884
closes: #44884
After a 401, we call the
/loginendpoint that will retrieve the auth_manager login URL and redirect us to it.Tested both with
SimpleAuthManagerandFABAuthManagernextquery param