-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Create list backfills tab in dag page #46772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, just one thing to clean.
Also we need to rebase and fix conflics.
Maybe created_at and completed_at could be a nice information to display because it will make it easier to see if the backfill is still running or if it is completed.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks.
0935631 to
7b7e6c5
Compare
|
Resolved the conflict and added an icon for the backfills tab, we can update that if it's not the right icon. |
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise lgtm
* WIP: List Backfills * Resolve review comments * Removed id and split dates into from-to * Updated duration * Append s to duration field * Remove sorting and adding new columns * Updated icon in dag
* WIP: List Backfills * Resolve review comments * Removed id and split dates into from-to * Updated duration * Append s to duration field * Remove sorting and adding new columns * Updated icon in dag


Closes: #43967
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.