-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Create list backfills tab in dag page #46772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b4aa81b
WIP: List Backfills
aritra24 e5da76e
Resolve review comments
aritra24 d8ecd36
Removed id and split dates into from-to
aritra24 0e2fa7d
Updated duration
aritra24 c6f66e6
Append s to duration field
aritra24 3033149
Remove sorting and adding new columns
aritra24 7b7e6c5
Updated icon in dag
aritra24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| /*! | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import { Box, Heading, Text } from "@chakra-ui/react"; | ||
| import type { ColumnDef } from "@tanstack/react-table"; | ||
| import { useParams } from "react-router-dom"; | ||
|
|
||
| import { useBackfillServiceListBackfills } from "openapi/queries"; | ||
| import type { BackfillResponse } from "openapi/requests/types.gen"; | ||
| import { DataTable } from "src/components/DataTable"; | ||
| import { useTableURLState } from "src/components/DataTable/useTableUrlState"; | ||
| import { ErrorAlert } from "src/components/ErrorAlert"; | ||
| import Time from "src/components/Time"; | ||
| import { reprocessBehaviors } from "src/constants/reprocessBehaviourParams"; | ||
| import { getDuration, pluralize } from "src/utils"; | ||
|
|
||
| const columns: Array<ColumnDef<BackfillResponse>> = [ | ||
| { | ||
| accessorKey: "reprocess_behavior", | ||
| cell: ({ row }) => ( | ||
| <Text> | ||
| { | ||
| reprocessBehaviors.find((rb: { value: string }) => rb.value === row.original.reprocess_behavior) | ||
| ?.label | ||
| } | ||
| </Text> | ||
| ), | ||
| enableSorting: false, | ||
| header: "Reprocess Behavior", | ||
| }, | ||
| { | ||
| accessorKey: "max_active_runs", | ||
| enableSorting: false, | ||
| header: "Max Active Runs", | ||
| }, | ||
| { | ||
| accessorKey: "created_at", | ||
| cell: ({ row }) => ( | ||
| <Text> | ||
| <Time datetime={row.original.created_at} /> | ||
| </Text> | ||
| ), | ||
| enableSorting: false, | ||
| header: "Created at", | ||
| }, | ||
| { | ||
| accessorKey: "completed_at", | ||
| cell: ({ row }) => ( | ||
| <Text> | ||
| <Time datetime={row.original.completed_at} /> | ||
| </Text> | ||
| ), | ||
| enableSorting: false, | ||
| header: "Completed at", | ||
| }, | ||
| { | ||
| accessorKey: "date_from", | ||
| cell: ({ row }) => ( | ||
| <Text> | ||
| <Time datetime={row.original.from_date} /> | ||
| </Text> | ||
| ), | ||
| enableSorting: false, | ||
| header: "From", | ||
| }, | ||
| { | ||
| accessorKey: "date_to", | ||
| cell: ({ row }) => ( | ||
| <Text> | ||
| <Time datetime={row.original.to_date} /> | ||
| </Text> | ||
| ), | ||
| enableSorting: false, | ||
| header: "To", | ||
| }, | ||
| { | ||
| accessorKey: "duration", | ||
| cell: ({ row }) => ( | ||
| <Text> | ||
| {row.original.completed_at === null | ||
| ? "" | ||
| : `${getDuration(row.original.created_at, row.original.completed_at)}s`} | ||
| </Text> | ||
| ), | ||
| enableSorting: false, | ||
| header: "Duration", | ||
| }, | ||
| ]; | ||
|
|
||
| export const Backfills = () => { | ||
| const { setTableURLState, tableURLState } = useTableURLState(); | ||
|
|
||
| const { pagination } = tableURLState; | ||
|
|
||
| const { dagId = "" } = useParams(); | ||
|
|
||
| const { data, error, isFetching, isLoading } = useBackfillServiceListBackfills({ | ||
| dagId, | ||
| limit: pagination.pageSize, | ||
| offset: pagination.pageIndex * pagination.pageSize, | ||
| }); | ||
|
|
||
| return ( | ||
| <Box> | ||
| <ErrorAlert error={error} /> | ||
| <Heading my={1} size="md"> | ||
| {pluralize("Backfill", data ? data.total_entries : 0)} | ||
| </Heading> | ||
| <DataTable | ||
| columns={columns} | ||
| data={data ? data.backfills : []} | ||
| isFetching={isFetching} | ||
| isLoading={isLoading} | ||
| modelName="Backfill" | ||
| onStateChange={setTableURLState} | ||
| total={data ? data.total_entries : 0} | ||
| /> | ||
| </Box> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /*! | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| export { Backfills } from "./Backfills"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.