Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Feb 16, 2025


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk force-pushed the move-providers-tests-to-unit branch from 0f2d491 to 2131f60 Compare February 16, 2025 10:45
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The git diff and local checking approach is the way to go, the browser freezes a lot in the UI:)

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was OK'ish via Web UI as well this time :-D

@potiuk
Copy link
Member Author

potiuk commented Feb 16, 2025

Was OK'ish via Web UI as well this time :-D

Yeah. Lots of renames, but it was just "OK-ish" .. Git dff took me less than a minute and I found a few things to fix from initial version :D

@potiuk potiuk merged commit 4d5846f into apache:main Feb 16, 2025
89 checks passed
@potiuk potiuk deleted the move-providers-tests-to-unit branch February 16, 2025 11:34
@potiuk
Copy link
Member Author

potiuk commented Feb 16, 2025

And merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants