-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove old provider references and replace "new" with just providers #46810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one nit and some error in docs (uff).
Otherwise - looking good.
70d4402 to
9ca501b
Compare
Applied nit fixes, also hopefuly the constraint/provider generation with suffix as well |
9ca501b to
607ebe9
Compare
1e63d10 to
b5ba46f
Compare
c1440a6 to
fdc6ecc
Compare
gopidesupavan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool :)
|
FYI: also cc: @eladkal -> while fixing provider doc generation in the PR (was failing when generating fab) I also re-enabled (that was commented out with a TODO for me to re-enable) linting of the generated .rst files and found out that for FAB with 1.5.2 the generated documentation is not valid (repeated links in commits.rst). Also I forward-ported FAB changes from 1.5.3 |
There was a lot of code and references to old provider ways of handling old structure of providers. Once all providers have been moved, we can now remove that old code and rename old the "new_providers" references to just "providers"
fdc6ecc to
e168f85
Compare
…pache#46810) There was a lot of code and references to old provider ways of handling old structure of providers. Once all providers have been moved, we can now remove that old code and rename old the "new_providers" references to just "providers"
…pache#46810) There was a lot of code and references to old provider ways of handling old structure of providers. Once all providers have been moved, we can now remove that old code and rename old the "new_providers" references to just "providers"
There was a lot of code and references to old provider ways of handling old structure of providers. Once all providers have been moved, we can now remove that old code and rename old the "new_providers" references to just "providers"
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.