Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Feb 16, 2025

There was a lot of code and references to old provider ways of handling old structure of providers. Once all providers have been moved, we can now remove that old code and rename old the "new_providers" references to just "providers"


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one nit and some error in docs (uff).
Otherwise - looking good.

@potiuk potiuk force-pushed the remove-old-providers-related-code branch from 70d4402 to 9ca501b Compare February 16, 2025 20:12
@potiuk
Copy link
Member Author

potiuk commented Feb 16, 2025

Found one nit and some error in docs (uff). Otherwise - looking good.

Applied nit fixes, also hopefuly the constraint/provider generation with suffix as well

@potiuk potiuk force-pushed the remove-old-providers-related-code branch from 9ca501b to 607ebe9 Compare February 16, 2025 20:16
@potiuk potiuk force-pushed the remove-old-providers-related-code branch 2 times, most recently from 1e63d10 to b5ba46f Compare February 17, 2025 11:34
@potiuk potiuk requested a review from Fokko as a code owner February 17, 2025 11:34
@potiuk potiuk force-pushed the remove-old-providers-related-code branch 2 times, most recently from c1440a6 to fdc6ecc Compare February 17, 2025 11:56
Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool :)

@potiuk
Copy link
Member Author

potiuk commented Feb 17, 2025

FYI: also cc: @eladkal -> while fixing provider doc generation in the PR (was failing when generating fab) I also re-enabled (that was commented out with a TODO for me to re-enable) linting of the generated .rst files and found out that for FAB with 1.5.2 the generated documentation is not valid (repeated links in commits.rst). Also I forward-ported FAB changes from 1.5.3

There was a lot of code and references to old provider ways of handling
old structure of providers. Once all providers have been moved, we can
now remove that old code and rename old the "new_providers" references
to just "providers"
@potiuk potiuk force-pushed the remove-old-providers-related-code branch from fdc6ecc to e168f85 Compare February 17, 2025 12:36
@potiuk potiuk merged commit e23d53f into apache:main Feb 17, 2025
89 checks passed
@potiuk potiuk deleted the remove-old-providers-related-code branch February 17, 2025 13:23
dantonbertuol pushed a commit to dantonbertuol/airflow that referenced this pull request Feb 17, 2025
…pache#46810)

There was a lot of code and references to old provider ways of handling
old structure of providers. Once all providers have been moved, we can
now remove that old code and rename old the "new_providers" references
to just "providers"
ntr pushed a commit to ntr/airflow that referenced this pull request Feb 20, 2025
…pache#46810)

There was a lot of code and references to old provider ways of handling
old structure of providers. Once all providers have been moved, we can
now remove that old code and rename old the "new_providers" references
to just "providers"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants