Skip to content

Airbyte Provider: api_version on on_kill method in AirbyteTriggerSyncOperator #46833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Feb 20, 2025
Merged

Airbyte Provider: api_version on on_kill method in AirbyteTriggerSyncOperator #46833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/airbyte/src/airflow/providers/airbyte/operators/airbyte.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def execute_complete(self, context: Context, event: Any = None) -> None:

def on_kill(self):
"""Cancel the job if task is cancelled."""
hook = AirbyteHook(airbyte_conn_id=self.airbyte_conn_id, api_type=self.api_type)
hook = AirbyteHook(airbyte_conn_id=self.airbyte_conn_id, api_version=self.api_version)
if self.job_id:
self.log.info("on_kill: cancel the airbyte Job %s", self.job_id)
hook.cancel_job(self.job_id)
17 changes: 17 additions & 0 deletions providers/airbyte/tests/unit/airbyte/operators/test_airbyte.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,20 @@ def test_execute(self, mock_wait_for_job, mock_submit_sync_connection):
mock_wait_for_job.assert_called_once_with(
job_id=self.job_id, wait_seconds=self.wait_seconds, timeout=self.timeout
)

@mock.patch("airflow.providers.airbyte.hooks.airbyte.AirbyteHook.cancel_job")
def test_on_kill(self, mock_cancel_job):
conn = Connection(conn_id=self.airbyte_conn_id, conn_type="airbyte", host="airbyte.com")
db.merge_conn(conn)

op = AirbyteTriggerSyncOperator(
task_id="test_Airbyte_op",
airbyte_conn_id=self.airbyte_conn_id,
connection_id=self.connection_id,
wait_seconds=self.wait_seconds,
timeout=self.timeout,
)
op.job_id = self.job_id
op.on_kill()

mock_cancel_job.assert_called_once_with(self.job_id)
Loading