Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3866] Run docker-compose pull silently #4688

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 11, 2019

To reduce the output in Travis. We don't care about the progress of the images being pulled from Dockerhub.

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

To reduce the output in Travis
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #4688 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4688      +/-   ##
==========================================
+ Coverage   74.35%   74.35%   +<.01%     
==========================================
  Files         430      430              
  Lines       27962    27962              
==========================================
+ Hits        20790    20792       +2     
+ Misses       7172     7170       -2
Impacted Files Coverage Δ
airflow/models/__init__.py 92.79% <0%> (+0.05%) ⬆️
airflow/contrib/operators/ssh_operator.py 85% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d2615...d134d20. Read the comment docs.

@ashb ashb merged commit 07ac00d into apache:master Feb 11, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Mar 27, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants