Use run_id to implement ti clear in API when given #46883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
Previously, the API converts dag_run_id from the request into a start/end date pair to call the underlying Python function. This however does not work correctly if the requested DAG run has logical_date=None, resulting in both start/end dates to be set to None, and ALL DAG runs selected. Since the underlying Python function accepts a run_id directly, we can simply pass in dag_run_id in the API implementation instead to get the correct result.
uranusjr
force-pushed
the
fix-api-clear-ti
branch
from
0035e1e to
604b58f
Compare
Member
|
This will fix the first issue, but what should |
ashb
approved these changes
Feb 19, 2025
Member
Author
|
We should probably either disable them or make them do nothing. There’s no corresponding Python function for them too. |
1 task
ntr
pushed a commit
to ntr/airflow
that referenced
this pull request
Feb 20, 2025
Previously, the API converts dag_run_id from the request into a start/end date pair to call the underlying Python function. This however does not work correctly if the requested DAG run has logical_date=None, resulting in both start/end dates to be set to None, and ALL DAG runs selected. Since the underlying Python function accepts a run_id directly, we can simply pass in dag_run_id in the API implementation instead to get the correct result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the API converts dag_run_id from the request into a start/end date pair to call the underlying Python function. This however does not work correctly if the requested DAG run has logical_date=None, resulting in both start/end dates to be set to None, and ALL DAG runs selected.
Since the underlying Python function accepts a run_id directly, we can simply pass in dag_run_id in the API implementation instead to get the correct result.
Fix #46804.