Skip to content

Fix new UI when running outside of breeze #46991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashb merged 2 commits into from
Feb 23, 2025
Merged

Fix new UI when running outside of breeze #46991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2295e3e
Fix new UI when running outside of breeze
jedcunningham Feb 23, 2025
3f022f8
Fix hardcoded tests
jedcunningham Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/config_templates/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2697,4 +2697,4 @@ fastapi:
version_added: ~
type: string
example: ~
default: "http://localhost:29091"
default: "http://localhost:9091"
1 change: 1 addition & 0 deletions dev/breeze/src/airflow_breeze/params/shell_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,7 @@ def env_variables_for_docker_commands(self) -> dict[str, str]:
_set_var(_env, "AIRFLOW_VERSION", self.airflow_version)
_set_var(_env, "AIRFLOW__CELERY__BROKER_URL", self.airflow_celery_broker_url)
_set_var(_env, "AIRFLOW__CORE__EXECUTOR", self.executor)
_set_var(_env, "AIRFLOW__FASTAPI__BASE_URL", f"http://localhost:{FASTAPI_API_HOST_PORT}")
if self.executor == EDGE_EXECUTOR:
_set_var(
_env, "AIRFLOW__CORE__EXECUTOR", "airflow.providers.edge.executors.edge_executor.EdgeExecutor"
Expand Down
2 changes: 1 addition & 1 deletion providers/amazon/tests/unit/amazon/aws/auth_manager/test_aws_auth_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ def test_filter_permitted_dag_ids(self, methods, user, auth_manager, test_user):

def test_get_url_login(self, auth_manager):
result = auth_manager.get_url_login()
assert result == "http://localhost:29091/auth/login"
assert result == "http://localhost:9091/auth/login"

def test_get_cli_commands_return_cli_commands(self, auth_manager):
assert len(auth_manager.get_cli_commands()) > 0
2 changes: 1 addition & 1 deletion providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ class TestSecurityManager:

def test_get_url_login(self, auth_manager):
result = auth_manager.get_url_login()
assert result == "http://localhost:29091/auth/login"
assert result == "http://localhost:9091/auth/login"

@pytest.mark.db_test
def test_get_url_logout_when_auth_view_not_defined(self, auth_manager_with_appbuilder):
Expand Down
Loading