Skip to content

Conversation

@wei-juncheng
Copy link
Contributor

closes: #45841

  • Implementation
  • E2E Test

What

  • I added description text for the fields on the Trino connection creation page to make it easier for users to operate client tags and other connection-related settings.

How

  • providers/trino/src/airflow/providers/trino/hooks/trino.py
    • Implement get_ui_field_behaviour() to display tooltip text on the fields in the webserver UI.

Test

  • I followed the instructions on the page to operate the client tag feature in my local environment and successfully added client tags information to the Trino query.
    • 截圖 2025-02-24 上午12 09 11
    • 截圖 2025-02-23 下午11 49 00
    • 截圖 2025-02-23 下午11 50 23

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@wei-juncheng wei-juncheng changed the title Add Trino connection UI fields placeholders Add Trino Connection UI Fields Placeholders Feb 23, 2025
@wei-juncheng wei-juncheng marked this pull request as ready for review February 23, 2025 17:10
@potiuk potiuk merged commit 7700687 into apache:main Feb 24, 2025
61 checks passed
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 28, 2025
* Add extra fields placeholders in Trino connection UI

* remove import

* fix CI
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* Add extra fields placeholders in Trino connection UI

* remove import

* fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for client_tags in TrinoHook Connections

3 participants