Add requires_result_fetch Configuration to SQLExecuteQueryOperator #46997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdenKik
changed the title
nevcohen
reviewed
Feb 23, 2025
Contributor
nevcohen
left a comment
nevcohen
left a comment
There was a problem hiding this comment.
Looks great! Just add also unitest for this case
EdenKik
force-pushed
the
fix/trino-requires-result-fetch
branch
from
6339f7e to
91630a2
Compare
nevcohen
reviewed
Feb 24, 2025
providers/common/sql/tests/unit/common/sql/operators/test_sql.py
Outdated
Show resolved
Hide resolved
providers/common/sql/tests/unit/common/sql/operators/test_sql.py
Outdated
Show resolved
Hide resolved
providers/common/sql/tests/unit/common/sql/operators/test_sql.py
Outdated
Show resolved
Hide resolved
EdenKik
force-pushed
the
fix/trino-requires-result-fetch
branch
from
91630a2 to
59739b4
Compare
Contributor
Author
|
@nevcohen |
EdenKik
force-pushed
the
fix/trino-requires-result-fetch
branch
from
59739b4 to
846a62b
Compare
nevcohen
approved these changes
Mar 2, 2025
Contributor
nevcohen
left a comment
nevcohen
left a comment
There was a problem hiding this comment.
All due respect! Looks great!
EdenKik
force-pushed
the
fix/trino-requires-result-fetch
branch
from
846a62b to
893d966
Compare
Contributor
Author
|
@potiuk |
potiuk
force-pushed
the
fix/trino-requires-result-fetch
branch
from
893d966 to
6a1d049
Compare
Member
|
Rebased and re-run - but there were some mypy checks. Please ping me if you solve them or in case rebase will see them green |
Contributor
Author
Seems like all checks have passed successfully |
potiuk
approved these changes
Apr 1, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…pache#46997) * Added configuration to allow fetch results in SQLExecuteQueryOperator * Fix Trino example with SQLExecuteQueryOperator * Add unit test for requires_result_fetch in SQLExecuteQueryOperator
diogotrodrigues
pushed a commit
to diogotrodrigues/airflow
that referenced
this pull request
Apr 6, 2025
…pache#46997) * Added configuration to allow fetch results in SQLExecuteQueryOperator * Fix Trino example with SQLExecuteQueryOperator * Add unit test for requires_result_fetch in SQLExecuteQueryOperator
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
…pache#46997) * Added configuration to allow fetch results in SQLExecuteQueryOperator * Fix Trino example with SQLExecuteQueryOperator * Add unit test for requires_result_fetch in SQLExecuteQueryOperator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration option within SQLExecuteQueryOperator: requires_output_processing.
When True, the operator ensures that query results are fetched, preventing premature cancellations (required for Trino and similar engines).
When False, it behaves as before, skipping result processing if not needed.
closes: #46808
related: #46808