-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix Azure Spot Containers unhealthy loop issue #47023 #47030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Could you please include a unit test case for this new addition? Since we now have a new condition, it is worth checking.
Happy to, are there unit tests already for the Azure Container Instances class? I'm having trouble finding them. If not I'll write some new ones. Thanks |
Nice! Sure, you can find them here https://github.com/apache/airflow/blob/main/providers/microsoft/azure/tests/unit/microsoft/azure/operators/test_container_instances.py. All the providers have their unit tests under their directory and then |
Hey, I'm having trouble running the tests even w/o any changes. I've followed the install and testing instructions on the INSTALL markdown but keep getting hit with the below.
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Fixes: #47023
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.