Skip to content

Conversation

@johnhoran
Copy link
Contributor


This adds support for on_pod_manifest_created, on_pod_completion and on_pod_teardown to the kubernetes pod operator when it is running in deffered mode. These callbacks are already supported in non-deferred mode, on_pod_manifest_created runs prior to the task deferring and on_pod_completion and on_pod_teardown run after the pod is completed, when the operator resumes in order to cleanup the pod.

@boring-cyborg boring-cyborg bot added the provider:cncf-kubernetes Kubernetes (k8s) provider related issues label Feb 26, 2025
@potiuk
Copy link
Member

potiuk commented Apr 1, 2025

Needs rebase.

@johnhoran johnhoran force-pushed the kubernetes-defer-callback branch from 9eee6fd to 46f6eca Compare April 8, 2025 15:34
@johnhoran
Copy link
Contributor Author

@potiuk rebased

@johnhoran johnhoran force-pushed the kubernetes-defer-callback branch from 3e20efc to 03fcd9f Compare June 16, 2025 12:43
@johnhoran johnhoran marked this pull request as draft July 22, 2025 15:53
@johnhoran johnhoran marked this pull request as ready for review July 22, 2025 17:39
@eladkal eladkal requested a review from romsharon98 July 23, 2025 07:48
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 8, 2025
Copy link
Contributor

@romsharon98 romsharon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk potiuk merged commit 895e8ed into apache:main Oct 13, 2025
90 checks passed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
* test print

* uv test

* add defer callbacks

* cleanup

* remove redundant call

* move test to async

* add callbacks to test

* cleanup

* format

* Update pod.py

* space

* ruff fix

* merge recent changes

* fix pass args

* fix type
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
* test print

* uv test

* add defer callbacks

* cleanup

* remove redundant call

* move test to async

* add callbacks to test

* cleanup

* format

* Update pod.py

* space

* ruff fix

* merge recent changes

* fix pass args

* fix type
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
* test print

* uv test

* add defer callbacks

* cleanup

* remove redundant call

* move test to async

* add callbacks to test

* cleanup

* format

* Update pod.py

* space

* ruff fix

* merge recent changes

* fix pass args

* fix type
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
* test print

* uv test

* add defer callbacks

* cleanup

* remove redundant call

* move test to async

* add callbacks to test

* cleanup

* format

* Update pod.py

* space

* ruff fix

* merge recent changes

* fix pass args

* fix type
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
* test print

* uv test

* add defer callbacks

* cleanup

* remove redundant call

* move test to async

* add callbacks to test

* cleanup

* format

* Update pod.py

* space

* ruff fix

* merge recent changes

* fix pass args

* fix type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:cncf-kubernetes Kubernetes (k8s) provider related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants