AIP-84 - Add Auth for Assets #47136

rawwar · 2025-02-27T07:06:31Z

related to #42360

Pending:

tests for 403

When I renamed the command to start the fastapi api server, I missed updating the breeze config to reflect the new config section.

…AIP-84/auth/asset

pierrejeambrun

thanks

tests/api_fastapi/conftest.py

tests/api_fastapi/core_api/routes/public/test_assets.py

…AIP-84/auth/asset

rawwar · 2025-03-01T07:15:55Z

@pierrejeambrun , We now have an Asset Alias. Can we consider this as an Asset Access Entity? Similar to how Dag runs is a Dag Access Entity.

Or should these be considered a separate entity and create AssetAliasDetail? As alias will have its own id and use invokes API with /assets/aliases/{asset_alias_id},. We will not get any info about the asset_id here.

providers/amazon/src/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py

pierrejeambrun

Overall looks good.

A few small suggestions.

airflow/api_fastapi/core_api/openapi/v1-generated.yaml

airflow/api_fastapi/core_api/routes/public/dag_run.py

airflow/api_fastapi/core_api/security.py

airflow/auth/managers/models/resource_details.py

newsfragments/42360.significant.rst

rawwar · 2025-03-03T23:58:32Z

@pierrejeambrun , We now have an Asset Alias. Can we consider this as an Asset Access Entity? Similar to how Dag runs is a Dag Access Entity.

Or should these be considered a separate entity and create AssetAliasDetail? As alias will have its own id and use invokes API with /assets/aliases/{asset_alias_id},. We will not get any info about the asset_id here.

I've separated out asset alias endpoints to a separate PR - #47241

…AIP-84/auth/asset

pierrejeambrun · 2025-03-05T13:39:06Z

There's one comment un-addressed, otherwise looks good.

…AIP-84/auth/asset

* Fix breeze api-server - missed it during config move When I renamed the command to start the fastapi api server, I missed updating the breeze config to reflect the new config section. * init asset * update rest * add commit session after creating dags * fix issue with time_machine * session commit in make_dag_with_multiple_versions * fix ci failure * add unauthorized user tests * fix * fix * move dag.sync_to_db to end * pr feedback * fix * replace uri with id in AssetDetails * remove asset alias tests * remove unused session * add newsfragment * rename newsfragment * use lambda --------- Co-authored-by: Jed Cunningham <jedcunningham@apache.org>

jedcunningham and others added 3 commits February 25, 2025 20:38

Fix breeze api-server - missed it during config move

652ffec

When I renamed the command to start the fastapi api server, I missed updating the breeze config to reflect the new config section.

Merge branch 'main' of https://github.com/apache/airflow

8a7d13b

Merge branch 'main' of https://github.com/apache/airflow

3287db5

boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Feb 27, 2025

rawwar added 2 commits February 27, 2025 12:41

Merge branch 'main' of https://github.com/apache/airflow

5e164be

init asset

44e9883

rawwar force-pushed the kalyan/AIP-84/auth/asset branch from 8371e29 to 44e9883 Compare February 27, 2025 07:27

rawwar added 7 commits February 27, 2025 15:01

update rest

9ab9066

Merge branch 'main' of https://github.com/apache/airflow into kalyan/…

7b9898b

…AIP-84/auth/asset

add commit session after creating dags

4976819

Merge branch 'main' of https://github.com/apache/airflow into kalyan/…

1b69bc0

…AIP-84/auth/asset

fix issue with time_machine

e3b411b

Merge branch 'main' of https://github.com/apache/airflow into kalyan/…

113f907

…AIP-84/auth/asset

session commit in make_dag_with_multiple_versions

39a35b1

rawwar marked this pull request as ready for review February 27, 2025 18:26

rawwar requested review from bbovenzi, ephraimbuddy, jscheffl, pierrejeambrun and ryanahamilton as code owners February 27, 2025 18:26

rawwar added 3 commits February 28, 2025 00:28

fix ci failure

1183e20

add unauthorized user tests

67b009b

fix

c5e805b

jason810496 mentioned this pull request Feb 28, 2025

AIP-84 | Add Auth for Dags #47062

Merged

rawwar added 2 commits February 28, 2025 18:29

fix

f1b9de1

Merge branch 'main' of https://github.com/apache/airflow into kalyan/…

c4aa05f

…AIP-84/auth/asset

pierrejeambrun reviewed Feb 28, 2025

View reviewed changes

tests/api_fastapi/conftest.py Outdated Show resolved Hide resolved

tests/api_fastapi/core_api/routes/public/test_assets.py Show resolved Hide resolved

rawwar added 2 commits February 28, 2025 22:31

move dag.sync_to_db to end

eb92a90

Merge branch 'main' of https://github.com/apache/airflow into kalyan/…

c667c6b

…AIP-84/auth/asset

rawwar added 3 commits February 28, 2025 23:00

pr feedback

978b9cb

fix

92d6b16

Merge branch 'main' of https://github.com/apache/airflow into kalyan/…

89b677e

…AIP-84/auth/asset

replace uri with id in AssetDetails

fd75ec2

rawwar requested review from eladkal and o-nikolas as code owners March 1, 2025 10:27

remove asset alias tests

2cf9699

rawwar commented Mar 1, 2025

View reviewed changes

providers/amazon/src/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py Show resolved Hide resolved

remove unused session

83bce17

pierrejeambrun reviewed Mar 3, 2025

View reviewed changes

rawwar added 2 commits March 3, 2025 21:43

pull from main

9ae6b95

add newsfragment

f0fc5ac

rawwar commented Mar 3, 2025

View reviewed changes

newsfragments/42360.significant.rst Show resolved Hide resolved

pull from main

09a5135

jedcunningham added the AIP-84 Modern Rest API label Mar 4, 2025

rawwar added 3 commits March 5, 2025 09:29

rename newsfragment

de5ab58

Merge branch 'main' of https://github.com/apache/airflow into kalyan/…

4c2a014

…AIP-84/auth/asset

use lambda

8835427

pierrejeambrun added the full tests needed We need to run full set of tests for this PR to merge label Mar 5, 2025

pierrejeambrun closed this Mar 5, 2025

pierrejeambrun reopened this Mar 5, 2025

This comment was marked as outdated.

Sign in to view

Merge branch 'main' of https://github.com/apache/airflow into kalyan/…

8527972

…AIP-84/auth/asset

pierrejeambrun approved these changes Mar 6, 2025

View reviewed changes

pierrejeambrun merged commit 50ff8b5 into apache:main Mar 6, 2025
89 checks passed

Lee-W mentioned this pull request Mar 6, 2025

AIP-84 Authentications and Permissions #42360

Closed

47 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AIP-84 - Add Auth for Assets #47136

AIP-84 - Add Auth for Assets #47136

Uh oh!

rawwar commented Feb 27, 2025 •

edited

Loading

Uh oh!

pierrejeambrun left a comment

Uh oh!

Uh oh!

Uh oh!

rawwar commented Mar 1, 2025

Uh oh!

Uh oh!

pierrejeambrun left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rawwar commented Mar 3, 2025

Uh oh!

pierrejeambrun commented Mar 5, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AIP-84 - Add Auth for Assets #47136

AIP-84 - Add Auth for Assets #47136

Uh oh!

Conversation

rawwar commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rawwar commented Mar 1, 2025

Uh oh!

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rawwar commented Mar 3, 2025

Uh oh!

pierrejeambrun commented Mar 5, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rawwar commented Feb 27, 2025 •

edited

Loading