Edge worker maintenance mode can be set from cli #47140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:edge
jscheffl
reviewed
Feb 27, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Small nit. Else looking good. But need a moment for full review. Will respond later
Contributor
AutomationDev85
left a comment
AutomationDev85
left a comment
There was a problem hiding this comment.
I like this feature. Nice job. Added some small comments.
providers/edge/src/airflow/providers/edge/worker_api/routes/worker.py
Outdated
Show resolved
Hide resolved
jscheffl
approved these changes
Feb 27, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Oh, that was a medium large one. Took a moment to digest. Looks good for me!
Cool now maintenance can be made via CLI!
AutomationDev85
approved these changes
Feb 27, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 28, 2025
* Edge worker maintenance mode can be set from cli * apply review findings * add misc * delete outdated code part --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
Sharashchandra
pushed a commit
to Sharashchandra/airflow
that referenced
this pull request
Feb 28, 2025
* Edge worker maintenance mode can be set from cli * apply review findings * add misc * delete outdated code part --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Edge worker maintenance mode can be set from cli * apply review findings * add misc * delete outdated code part --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge worker can be send to maintenance mode via cli, and back.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.