-
Notifications
You must be signed in to change notification settings - Fork 16.3k
fix: OpenLineage serialization of dataset timetables for Airflow 2.9 #47150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
acd6560 to
f83b328
Compare
f83b328 to
e150728
Compare
e150728 to
35ef7eb
Compare
|
@mobuchowski -> would you like to take a look ? |
|
Looks good to me 🙂 |
Backport failed to create: v2-10-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 57986c0 v2-10-testThis should apply the commit to the v2-10-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
This is provider only PR. No need to backport to 2.10 branch |
|
Need - likely -manual cherry-picking @kacpermuda |
|
Not sure if i understand, why would it need cherry-picking @potiuk ? If it's a provider only PR, it should be released in the next provider release correct? (OL provider still supports 2.9 Airflow, so there is no need for any backporting, if my thinking is correct 😄 ) EDIT: The PR contains fix only for how OL handles timetables in AF2.9 |
|
🤦 right, |
In #43434 we added OL support for serialization of timetables for Airflow 2.8 and 2.9. In 2.9 however, airflow introduced new ways of defining a dataset schedule that were not covered by our integration, so we received empty timetables. This PR fixes it, now timetable should be present and serialized in a similar way to how it looks like in 2.10+.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.