Skip to content

Conversation

@kacpermuda
Copy link
Contributor

In #43434 we added OL support for serialization of timetables for Airflow 2.8 and 2.9. In 2.9 however, airflow introduced new ways of defining a dataset schedule that were not covered by our integration, so we received empty timetables. This PR fixes it, now timetable should be present and serialized in a similar way to how it looks like in 2.10+.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kacpermuda kacpermuda force-pushed the fix-ol-ds-trigger-af29 branch 3 times, most recently from acd6560 to f83b328 Compare February 27, 2025 16:45
@kacpermuda kacpermuda marked this pull request as ready for review February 27, 2025 17:49
@kacpermuda kacpermuda force-pushed the fix-ol-ds-trigger-af29 branch from f83b328 to e150728 Compare February 27, 2025 19:05
@potiuk
Copy link
Member

potiuk commented Mar 2, 2025

@mobuchowski -> would you like to take a look ?

@mobuchowski
Copy link
Contributor

Looks good to me 🙂

@mobuchowski mobuchowski merged commit 57986c0 into apache:main Mar 2, 2025
61 checks passed
@github-actions
Copy link

github-actions bot commented Mar 2, 2025

Backport failed to create: v2-10-test. View the failure log Run details

Status Branch Result
v2-10-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 57986c0 v2-10-test

This should apply the commit to the v2-10-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@eladkal
Copy link
Contributor

eladkal commented Mar 2, 2025

This is provider only PR. No need to backport to 2.10 branch

@potiuk
Copy link
Member

potiuk commented Mar 2, 2025

Need - likely -manual cherry-picking @kacpermuda

@kacpermuda kacpermuda deleted the fix-ol-ds-trigger-af29 branch March 3, 2025 09:34
@kacpermuda
Copy link
Contributor Author

kacpermuda commented Mar 3, 2025

Not sure if i understand, why would it need cherry-picking @potiuk ? If it's a provider only PR, it should be released in the next provider release correct? (OL provider still supports 2.9 Airflow, so there is no need for any backporting, if my thinking is correct 😄 ) EDIT: The PR contains fix only for how OL handles timetables in AF2.9

@potiuk
Copy link
Member

potiuk commented Mar 12, 2025

🤦 right,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants