Skip to content

Conversation

@rahul-madaan
Copy link
Contributor

@rahul-madaan rahul-madaan commented Feb 27, 2025

This PR does 2 main things.

  1. Response from snowflake has changed after implementation, all the response have a "status" key which was causing inputs to go empty. It has been fixed by removing check on status key.
  2. We were returning deduplicated inputs at directory level instead at file level. As the naming convention doc says we need to have the object key in input name, I have fixed the implementation.

Closes: #47019


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:snowflake Issues related to Snowflake provider label Feb 27, 2025
@rahul-madaan rahul-madaan marked this pull request as draft February 27, 2025 19:43
Signed-off-by: Rahul Madan <madan.rahul9@gmail.com>
@rahul-madaan rahul-madaan marked this pull request as ready for review February 27, 2025 19:48
@rahul-madaan rahul-madaan requested a review from kacpermuda March 4, 2025 08:05
@rahul-madaan rahul-madaan requested a review from kacpermuda March 4, 2025 16:12
Copy link
Contributor

@kacpermuda kacpermuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rahul-madaan 🚀

@potiuk potiuk merged commit b599f6d into apache:main Mar 4, 2025
59 checks passed
shahar1 pushed a commit to shahar1/airflow that referenced this pull request Mar 5, 2025
…ageToSnowflakeOperator (apache#47168)



---------

Signed-off-by: Rahul Madan <madan.rahul9@gmail.com>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
…ageToSnowflakeOperator (apache#47168)



---------

Signed-off-by: Rahul Madan <madan.rahul9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:snowflake Issues related to Snowflake provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snowflake CopyFromExternalStageToSnowflake OpenLineage support not working

3 participants