-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix MSSQL provider dependency on common-sql #47188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MSSQL provider dependency on common-sql #47188
Conversation
|
Nice. But can you please install pre-commit and |
|
I improved contributor's doc and pyproject.toml comments here explaining what you need to do #47203 |
done @potiuk |
|
Static checks are still failing. Could you please run the following and commit? |
|
|
Likely because of this: > fastapi==0.115.9
---
> fastapi==0.115.10There is a new fastapi generated and it apparently generates new output - you will see the same thing in canary builds https://github.com/apache/airflow/actions/runs/13602495440 Your PR modifies dependencies, so (unlike most other PRs) we will attempt to resolve new dependencies using whatever has been released since the last time we "froze" dependencies in constraints. You can always see the list of updated dependencies in "summary" of the checks (just scroll down below the graph with the CI jobs and you will see what has been upgraded in your PR. I will separately fix it in |
|
Fastapi has been pinned temporarily already in main in #47233 . Rebasing to account for it. |
The MSSQL provider currently requires common-sql >= 1.20.0, but it's using the dialects module which was only introduced in common-sql 1.23.0. This change updates the dependency requirement to 1.23.0 to ensure proper functionality when installing the provider.
|
Another badly merged main failure fixed :) |
|
FINALLY :) |
|
yeah finally its done!! |
The MSSQL provider currently requires common-sql >= 1.20.0, but it's using the dialects module which was only introduced in common-sql 1.23.0. This change updates the dependency requirement to 1.23.0 to ensure proper functionality when installing the provider.
The MSSQL provider currently requires common-sql >= 1.20.0, but it's using the dialects module which was only introduced in common-sql 1.23.0. This change updates the dependency requirement to 1.23.0 to ensure proper functionality when installing the provider.

The MSSQL provider currently requires common-sql >= 1.20.0, but it's using the dialects module which was only introduced in common-sql 1.23.0.
Closes: #47185