Skip to content

Conversation

@AlteredOracle
Copy link
Contributor

@AlteredOracle AlteredOracle commented Feb 28, 2025

The MSSQL provider currently requires common-sql >= 1.20.0, but it's using the dialects module which was only introduced in common-sql 1.23.0.
Closes: #47185

@potiuk
Copy link
Member

potiuk commented Feb 28, 2025

Nice. But can you please install pre-commit and commit --amend ? This will auto-generate the rest of changes resulting from it? BTW. I will update the contributing docs to make it clearer :)

@potiuk
Copy link
Member

potiuk commented Feb 28, 2025

I improved contributor's doc and pyproject.toml comments here explaining what you need to do #47203

@AlteredOracle
Copy link
Contributor Author

AlteredOracle commented Feb 28, 2025

Nice. But can you please install pre-commit and commit --amend ? This will auto-generate the rest of changes resulting from it? BTW. I will update the contributing docs to make it clearer :)

done @potiuk

@bugraoz93
Copy link
Contributor

Static checks are still failing. Could you please run the following and commit?
pre-commit run --al-files
You can run pre-commit install this will make the hooks run in each commit.

@potiuk
Copy link
Member

potiuk commented Feb 28, 2025

breeze static-checks --only-my-changes should do the same.

@AlteredOracle
Copy link
Contributor Author

not sure why static is failing. It says Generate the FastAPI API spec...............................................Failed.

But is passes in local
image

@potiuk
Copy link
Member

potiuk commented Mar 1, 2025

not sure why static is failing. It says Generate the FastAPI API spec...............................................Failed.

Likely because of this:

> fastapi==0.115.9
---
> fastapi==0.115.10

There is a new fastapi generated and it apparently generates new output - you will see the same thing in canary builds https://github.com/apache/airflow/actions/runs/13602495440

Your PR modifies dependencies, so (unlike most other PRs) we will attempt to resolve new dependencies using whatever has been released since the last time we "froze" dependencies in constraints.

You can always see the list of updated dependencies in "summary" of the checks (just scroll down below the graph with the CI jobs and you will see what has been upgraded in your PR.

I will separately fix it in main - so once this is merged, you should be able to rebase and this one should be green then.

@potiuk
Copy link
Member

potiuk commented Mar 1, 2025

Fastapi has been pinned temporarily already in main in #47233 . Rebasing to account for it.

The MSSQL provider currently requires common-sql >= 1.20.0, but it's using
the dialects module which was only introduced in common-sql 1.23.0.

This change updates the dependency requirement to 1.23.0 to ensure proper
functionality when installing the provider.
@potiuk
Copy link
Member

potiuk commented Mar 1, 2025

Another badly merged main failure fixed :)

@potiuk
Copy link
Member

potiuk commented Mar 1, 2025

FINALLY :)

@potiuk potiuk merged commit c9bbfa5 into apache:main Mar 1, 2025
148 checks passed
@AlteredOracle
Copy link
Contributor Author

yeah finally its done!!

@AlteredOracle AlteredOracle deleted the fix-mssql-provider-dependency branch March 1, 2025 15:41
shahar1 pushed a commit to shahar1/airflow that referenced this pull request Mar 5, 2025
The MSSQL provider currently requires common-sql >= 1.20.0, but it's using
the dialects module which was only introduced in common-sql 1.23.0.

This change updates the dependency requirement to 1.23.0 to ensure proper
functionality when installing the provider.
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
The MSSQL provider currently requires common-sql >= 1.20.0, but it's using
the dialects module which was only introduced in common-sql 1.23.0.

This change updates the dependency requirement to 1.23.0 to ensure proper
functionality when installing the provider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"apache-airflow-providers-microsoft-mssql" is not checking for correct requirement

3 participants