Add method to retrieve Druid task status URL based on ingestion type #47238
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kanagaraj-dhanapal-patch-2
… kanagaraj-dhanapal-patch-2
Contributor
Author
|
@eladkal could you please review this PR |
Contributor
Author
|
@o-nikolas Could you please review this PR? |
potiuk
approved these changes
Mar 4, 2025
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
…pache#47238) --------- Co-authored-by: k0d04mr <kanagaraj.dhanapal@walmart.com>
67 tasks
Contributor
Author
|
Test the version apache-airflow-providers-apache-druid==4.1.0rc1 and its working fine |
Member
Thanks for letting us know ! Updated it in the "Status" issue :) |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…pache#47238) --------- Co-authored-by: k0d04mr <kanagaraj.dhanapal@walmart.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the get_status_url method in the DruidHook class to improve the handling of different ingestion types.
Changes
Updated the get_status_url method to return the correct status URL based on the ingestion type.
Added logic to handle the IngestionType.MSQ ingestion type separately.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.