Adding ticks to user provided table names #47262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @bugraoz93 as promised earlier :) |
bugraoz93
approved these changes
Mar 1, 2025
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Thanks for the changes, @amoghrajesh! :) It looks good!
This is causing a problem if the table name is chosen the way MySQL doesn't like :D
Maybe we need to add the backtick to table names in the tests as well. It seems it is not finding the call
Contributor
Author
|
Yep ill fix it later today! |
bugraoz93
approved these changes
Mar 3, 2025
Contributor
Author
|
@potiuk could you take a look again? |
potiuk
approved these changes
Mar 3, 2025
shahar1
pushed a commit
to shahar1/airflow
that referenced
this pull request
Mar 5, 2025
67 tasks
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysql provider has few helper methods that demand user input, and since users can input table names, we need to take care of situations when a keyword tablename is passed, rare but possible. For ex: if "where" is a table :)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.