Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIRFLOW-3911: Change Harvesting DAG parsing results to DEBUG log level #4729

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

nritholtz
Copy link
Contributor

@nritholtz nritholtz commented Feb 18, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    After upgrading to 1.10.2, I use INFO level for my DAG logs and started getting spammed by the message: "Harvesting DAG parsing results". This PR moves this statement to DEBUG level.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Change of log level.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

@feng-tao
Copy link
Member

lgtm

@feng-tao feng-tao merged commit 6a7e0b7 into apache:master Feb 19, 2019
@Fokko
Copy link
Contributor

Fokko commented Feb 19, 2019

Thanks for this one! 👍

antonimaciej pushed a commit to PolideaInternal/airflow that referenced this pull request Feb 26, 2019
@nritholtz nritholtz deleted the AIRFLOW-3911 branch March 11, 2019 18:56
ashb pushed a commit to ashb/airflow that referenced this pull request Mar 20, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants