Skip to content

Conversation

@vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Mar 3, 2025

Remove methods specific to Airflow 2 from auth manager interface and auth manager implementations. Now that Airflow 2 UI is gone, we can get rid of following methods in auth managers:

  • filter_permitted_menu_items
  • get_user_name
  • get_user_display_name
  • get_user
  • get_user_id
  • is_logged_in
  • get_url_logout
  • get_api_endpoints
  • register_views

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck vincbeck force-pushed the vincbeck/clean_am branch from f42524d to ba1d49e Compare March 3, 2025 21:16
@vincbeck vincbeck force-pushed the vincbeck/clean_am branch from ba1d49e to a02d2df Compare March 3, 2025 21:45
@vincbeck vincbeck requested a review from ashb as a code owner March 3, 2025 21:45
@vincbeck vincbeck force-pushed the vincbeck/clean_am branch 2 times, most recently from 369d794 to ea01577 Compare March 3, 2025 23:41
@vincbeck vincbeck force-pushed the vincbeck/clean_am branch from ea01577 to 9d7bc5c Compare March 4, 2025 14:56
@vincbeck vincbeck force-pushed the vincbeck/clean_am branch from 9d7bc5c to de15dd9 Compare March 4, 2025 16:04
@vincbeck vincbeck merged commit 96c0df6 into apache:main Mar 4, 2025
144 of 145 checks passed
@vincbeck vincbeck deleted the vincbeck/clean_am branch March 4, 2025 18:02
shahar1 pushed a commit to shahar1/airflow that referenced this pull request Mar 5, 2025
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants