serialize http transports contained in composite transport #47444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:common-compat
provider:openlineage
mobuchowski
force-pushed
the
openlineage-composite-transport-serialization
branch
3 times, most recently
from
813ac93 to
fca1c14
Compare
mobuchowski
force-pushed
the
openlineage-composite-transport-serialization
branch
2 times, most recently
from
1f82e52 to
fc875b8
Compare
kacpermuda
reviewed
Mar 10, 2025
Contributor
kacpermuda
left a comment
kacpermuda
left a comment
There was a problem hiding this comment.
Probably would be also good to add the support for HTTP transport within composite transport here.
providers/openlineage/src/airflow/providers/openlineage/plugins/macros.py
Outdated
Show resolved
Hide resolved
providers/common/compat/src/airflow/providers/common/compat/openlineage/utils/spark.py
Outdated
Show resolved
Hide resolved
mobuchowski
force-pushed
the
openlineage-composite-transport-serialization
branch
4 times, most recently
from
d4dc7d1 to
3d420f4
Compare
kacpermuda
reviewed
Mar 11, 2025
kacpermuda
approved these changes
Mar 11, 2025
Contributor
kacpermuda
left a comment
kacpermuda
left a comment
There was a problem hiding this comment.
Left one more comment about improving logging, but lgtm overall 🚀
mobuchowski
force-pushed
the
openlineage-composite-transport-serialization
branch
2 times, most recently
from
a1ea9a0 to
730f77b
Compare
mobuchowski
force-pushed
the
openlineage-composite-transport-serialization
branch
4 times, most recently
from
ae12725 to
014d8de
Compare
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski
force-pushed
the
openlineage-composite-transport-serialization
branch
from
014d8de to
1c181a0
Compare
potiuk
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we can pass OpenLineage transport information to Spark jobs using HttpTransport.
However, very common feature is using CompositeTransport to direct the data to multiple destinations - even if one of them is purely for debug.
This prevented the valid HttpTransport to be serialized. After this PR, we will still pass only HttpTransport configuration, but also when it's wrapped in CompositeTransport.