-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove the old task run commands and LocalTaskJob
#47453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
approved these changes
Mar 6, 2025
vincbeck
approved these changes
Mar 6, 2025
potiuk
approved these changes
Mar 6, 2025
210d1ce to
04b9dcf
Compare
Member
Author
|
I deleted LocalTaskJob too since it's tests were failing (and it was only used by |
jedcunningham
approved these changes
Mar 6, 2025
providers/celery/src/airflow/providers/celery/executors/celery_executor_utils.py
Outdated
Show resolved
Hide resolved
vincbeck
approved these changes
Mar 6, 2025
With the switch to Task SDK the hacky way we've had for 10 years of re-invoking our CLI processor can finally go the way of the Dodo. And since LocalTaskJob only existed to drive/monitor/heartbeat tasks from the CLI, that can go too.
04b9dcf to
3753490
Compare
task run commandstask run commands and LocalTaskJob
Contributor
|
This seems to break running example dags on the main branch in my laptop. Is this some issue with |
2 tasks
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch to Task SDK the hacky way we've had for 10 years of
re-invoking our CLI processor can finally go the way of the Dodo.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.