AIP-84 Add Auth for backfill #47482
AIP-84 Add Auth for backfill #47482
Conversation
vatsrahul1001
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
|
Let me know when this is ready for review. |
@vatsrahul1001 has mark it for ready to review. I'll also take a look later today |
There was a problem hiding this comment.
Can you rebase the branch and regenerate the openapi spec.
Some endpoints are missing the permissions (list_backfills, create_backfill, get_backfill etc.)
Also I think we might want an extra Entity for the AuthManager instead of going through dagrun every time. (That might be good for creating a backfill, to have both backfill + create dag run permission maybe, but for listing backfills, we need a dedicated entity I guess). You can take a look at this PR that also does that for AssetAliases:
#47241
|
cc: @vincbeck |
Lee-W
force-pushed
the
AIP84-auth-backfills
branch
from
3ceaf3d to
c40a5ef
Compare
I agree. I think #47241 is a great example, please follow it and tag me on the PR. I'll be happy to review it |
Lee-W
force-pushed
the
AIP84-auth-backfills
branch
from
c40a5ef to
7151649
Compare
providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py
Show resolved
Hide resolved
providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py
Show resolved
Hide resolved
Lee-W
force-pushed
the
AIP84-auth-backfills
branch
from
27c07f7 to
8784fe4
Compare
Lee-W
force-pushed
the
AIP84-auth-backfills
branch
from
2ccf6c0 to
dce6fd5
Compare
Lee-W
force-pushed
the
AIP84-auth-backfills
branch
from
dce6fd5 to
de4ccdf
Compare
providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py
Outdated
Show resolved
Hide resolved
Lee-W
force-pushed
the
AIP84-auth-backfills
branch
from
de4ccdf to
0119c4f
Compare
* add auth to backfills endpoints * feat(security): add is_authorized_backfill * feat(api_fastapi): add required permision for backfills * feat(AIP-84): add backfill operation permission to aws provider * test(AIP-84): add test cases for backfill auth * fixup! Merge branch 'main' into AIP84-auth-backfills * fixup! Merge branch 'main' into AIP84-auth-backfills * fixup! fixup! Merge branch 'main' into AIP84-auth-backfills * fixup! Merge branch 'main' into AIP84-auth-backfills * fixup! Merge branch 'main' into AIP84-auth-backfills --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
4 participants
related to #42360
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.