chore: Add warning to OpenLineage method when losing query_ids info #47489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:snowflake
Contributor
|
TBH I don't think log that's meant to be notifying users gives anyone anything. It's not like they can have a workaround for it. |
Contributor
Author
|
I partially agree, that this is more an internal problem of OL integration, but still i think it's good to let users know that the data they are receiving may not be complete. From the other hand, it has been working like this for years so maybe the impact is not that big. This warning can be removed once we implement a fix for it, but there is no clear ETA for it now. I won’t insist on this solution, but I think it might be helpful. |
Contributor
Author
|
Let's focus on the fix instead: #47736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #47488
Log a warning when information loss occurs and user is using OpenLineage. Fix will be included in separate PR, when we figure out how to best approach it.
cc @mobuchowski
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.